search

Cyfrin / foundry-defi-stablecoin-cu

241 stars 107 forks source link

OpenZeppelin changes in paths #75

Closed ghost closed 2 months ago

ghost commented 3 months ago

Change the import paths

cromewar commented 3 months ago

Hello @preslavsec, can you be more specific on this issue, please?

Also, consider sending a PR if you think changes must be made to the repo.

AndroKasrashvili commented 3 months ago

Mock path is updated in current version of openzeppelin, also in an updated version of ERC20Mock constructor does not receive any parameter.

to resolve the issue in HelperConfig use following import:

import {ERC20Mock} from "@openzeppelin/contracts/mocks/token/ERC20Mock.sol";
cromewar commented 3 months ago

Can you send us a PR with these changes? I will make sure the changes are merged.

AndroKasrashvili commented 3 months ago

Sure thing, will do on Monday.

cromewar commented 3 months ago

Thanks ser will be waiting for the PR :D

AndroKasrashvili commented 3 months ago

here you go buddy :) @cromewar https://github.com/Cyfrin/foundry-defi-stablecoin-f23/pull/76

ghost commented 3 months ago

ReentrancyGuard is in openzeppelin/contracts/utils

AndroKasrashvili commented 3 months ago

that's correct, please check pr #76

cromewar commented 2 months ago

@AndroKasrashvili I haven't merged this PR because, as you are using a newer version of Openzeppelin, there is a mismatch between the version you are using and the version existing on the MAKEFILE. Can you change the version on the MAKEFILE? That way I can merge the PR Right away.

PatrickAlphaC commented 2 months ago

I'm pushing a big update soon, stay tuned.