Need update for lesson 10 “Getting real world price data from Chainlink”

dovydasradziwill commented 3 months ago

Section

Section 4 | Fund Me

Could you please leave a link to the Cyfrin Updraft Lesson (or YouTube video timestamp) where this error occurs? (You can right click a video and "copy video URL at current time")

No response

Describe the bug

In lesson 10 “Getting real world price data from Chainlink” Section 3 “FundMe” for function getPrice uses old ChainlinkDocs codebase (interface and dataFeed): Old version (in video)

Actual code from Chainlink Docs (Using Data Feeds on EVM Chains | Chainlink Documentation) AggregatorV3Interface also has difference (chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol at develop · smartcontractkit/chainlink (github.com))

I wouldn't have focused on this issue if it weren't for the fact that students with a non-technical background (or without basic computer science knowledge) are writing Patrick's code during the course of the course, and as a result, they get an error. And after only half a section on working with Chainlink, the student is more likely to get lost in the massive documentation.

I also draw attention to the fact that the course repository also contains non-working code.

EngrPips commented 3 months ago

Hello @dovydasradziwill, Thanks for this contribution and this will be attended to appropriately as soon as possible.

cromewar commented 3 months ago

Thanks for the report @dovydasradziwill , we are going to publish and update on this on the lesson. Should be live in a couple of minutes.

Cyfrin / foundry-full-course-cu