Cyfrin / foundry-simple-storage-cu

32 stars 30 forks source link

Deploy script doesn't deploy. Is there some update to Foundry since recording? #12

Open ewebgh33 opened 8 months ago

ewebgh33 commented 8 months ago

Doing EXACTLY what Patrick says forge script script/DeploySimpleStorage.s.sol gives

Error: 
contract source info format must be `<path>:<contractname>` or `<contractname>`

Instead you should just do forge script DeploySimpleStorage So I assume there was some kind of update with Forge and syntax for deployement.

NB the error also isn't so helpful. I wasn't sure if the error was with my command in bash, or with one of the imports paths in the deploy script. As both (in this example at least) are a very simple path/filename.sol format, so to me it could have been either, IMO at least. This has been true of my experience with Foundry so far - the errors are all kind of vague.

PatrickAlphaC commented 8 months ago

Hmm... sorry to hear this, this is good feedback. forge script script/DeploySimpleStorage.s.sol should still work (it works for me), there might be an issue with how your paths are set up.

Can you try running exactly these commands?

git clone https://github.com/Cyfrin/foundry-simple-storage-f23
cd foundry-simple-storage-f23
forge build
forge script script/DeploySimpleStorage.s.sol
dvdbyte commented 7 months ago

forge build

I get the same error

Error: 
contract source info format must be `<path>:<contractname>` or `<contractname>`

but these 2 fixes help resolve the issue

forge script script/DeploySimpleStorage.s.sol:DeploySimpleStorage

or

forge script DeploySimpleStorage