search

Cyfrin / foundry-smart-contract-lottery-cu

47 stars 38 forks source link

Added testCheckUpkeepReturnsFalseIfEnoughTimeHasntPassed logic #45

Closed haard18 closed 5 months ago

haard18 commented 5 months ago

Adding Logic to the testCheckUpkeepReturnsFalseIfEnoughTimeHasntPassed. The logic warps time after entering in the raffle and it warps lesser than the Determined Interval and hence the checkupkeep is returned False

PatrickAlphaC commented 5 months ago

Thanks! This is more of a challenge for you, and for other who run into this! Going to close this PR, but nice work on the solution!

haard18 commented 5 months ago

Thankyou!!! Ik I just wanted to figure out the process of Contributing and you're such a HELP! Btw cannot Thankyou Enough for the knowledge you're Imparting!❤️

On Wed, 3 Apr 2024 at 04:50, Patrick Collins @.***> wrote:

Closed #45 https://github.com/Cyfrin/foundry-smart-contract-lottery-f23/pull/45.

— Reply to this email directly, view it on GitHub https://github.com/Cyfrin/foundry-smart-contract-lottery-f23/pull/45#event-12333072581, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6RWPAW5DIOEY75IRHCYXTTY3M4K5AVCNFSM6AAAAABFT2PP4CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMZTGMBXGI2TQMI . You are receiving this because you authored the thread.Message ID: <Cyfrin/foundry-smart-contract-lottery-f23/pull/45/issue_event/12333072581 @github.com>