Added security improvements to Vault solidity code

Cyfrin / solidity-by-example.github.io

Solidity By Example

https://solidity-by-example.org/

MIT License

614 stars 201 forks source link

Closed gowtham-the-dev closed 2 years ago

gowtham-the-dev commented 2 years ago

Changes Made:

Added logic in deposit and withdraw to mint and burn shares only if the token transfer is successful
Added logic in withdraw to revert if the caller doesn't have enough shares balance

Files Changed:

Kindly let me know if any changes needed. Thanks 🙂.

t4sk commented 2 years ago

Thanks for the PR but this won't be merged for the following reasons

Most ERC20 tokens never return false, so check on transfer is usually a waste of gas
Overflow / underflow halts transaction so the check on balance in redundant

gowtham-the-dev commented 2 years ago

Okay. Got it @t4sk.