search

CymaticLabs / Unity3D.Amqp

AMQP client library for Unity 3D supporting RabbitMQ
MIT License
97 stars 21 forks source link

Why is `AutomaticRecoveryEnabled` explicitly set to false? #11

Open tafs7 opened 5 years ago

tafs7 commented 5 years ago

@CymaticLabs @meverett, I just realized that ConnectionFactory.AutomaticRecoveryEnabled is explicitly set to false:

https://github.com/CymaticLabs/Unity3D.Amqp/blob/42ca5de66fcda21ef6a4040bade99118b2ad6374/src/CymaticLabs.Unity3D.Amqp/RabbitMq/RabbitMqBrokerConnection.cs#L335

Also, there's no property in this RabbitMqBrokerConnection wrapper that enables the consumer of this lib to set that RMQ client property via code.

Is there any specific reason why this was set to false explicitly for this wrapper? was there a concern with Unity and the broker connection during recovery?

I'd like to understand the reasoning for that decision, before I go and fork and change that myself and find some odd/edge-case issue that you may have already come up with and why you may have set this to false from the beginning.

thanks!

tafs7 commented 5 years ago

Bueller? Bueller? Anyone? @CymaticLabs @meverett