Cyn7hius / pe

0 stars 0 forks source link

No ending of lifeline in sequence diagram #15

Open Cyn7hius opened 2 years ago

Cyn7hius commented 2 years ago

image.png

The return arrow for writeJsonToCsv is placed in the middle of the activation bar, instead of at the end

nus-pe-bot commented 2 years ago

Team's Response

Activation bar is too long.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sequence Diagram in DG (Figure 5.5.1) has incorrect activation bar length

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


The activation bar for JsonUtil is too long (Does not end after returning):

image.png


[original: nus-cs2103-AY2122S1/pe-interim#1347] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Activation bar is too long. (parent of duplicate)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is not mutually exclusive with the other issue, this issue is due to diagram lacking an X in the lifeline like this. This is achieved by using destroy in puml. image.png

Whereas in the other issue, it is due to the activation bar not closing correctly, not the lifeline of the object. While it might be a similar issue in puml, in term of appearance to the reader, it is two separate issue.