Cynthesize / cynthesize-frontend

Frontend written in JS and deployed GraphQL for Cynthesize. Development build: https://cynthesize-develop.netlify.com
https://cynthesize.co
GNU General Public License v3.0
64 stars 51 forks source link

Add scrollbar in codeEditor #127

Open prijeshb opened 5 years ago

prijeshb commented 5 years ago

Describe the bug currently no scrollbar is loaded as you increase text cotent in editor, but instead size of Editor increases.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'existing project by adding it if do not have one or from profile section on top right corner'
  2. Click on 'Add issuse or comment on any project'
  3. See error

Expected behavior Vertical scrollbar is available for scrolling, if you add more content to editor.

Screenshots

In Comments

ezgif com-crop 1

On AddIssue

screenshot 175 1

Additional context You can find corresponding files from src/app/shared/comments folder

revanth-reddy commented 5 years ago

@prijeshb please assign me this issue

prijeshb commented 5 years ago

@revanth-reddy Assigned to you.

AdityaAnandKrishna commented 5 years ago

Can I work on this issue.

sanyamdogra commented 5 years ago

Hey @AdityaAnandKrishna, @revanth-reddy is already working on this issue. You may choose another.

prijeshb commented 5 years ago

@revanth-reddy Any updates ??

revanth-reddy commented 5 years ago

@prijeshb The scrollbar is hidden because of styling from node_modules/simplemde/dist/simplemde.min.css

where the code is .CodeMirror-scroll{ min-height:300px; }

which has to be changed to .CodeMirror-scroll{ height:300px; }

But Node_modules is added to git_ignore so direct change in css won't work because of git. I am still struck there.

WickedBrat commented 5 years ago

The best solution would be to remove the CSS property applied. Or If you want apply a CSS property, you may want to go for inline CSS.

On Sun, Feb 17, 2019, 1:21 PM Revanth Reddy <notifications@github.com wrote:

@prijeshb https://github.com/prijeshb The scrollbar is hidden because of styling from node_modules/simplemde/dist/simplemde.min.css

where the code is .CodeMirror-scroll{ min-height:300px; }

which has to be changed to .CodeMirror-scroll{ height:300px; }

But Node_modules is added to git_ignore so direct change in css won't work because of git. I am still struck there.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cynthesize/cynthesize-frontend/issues/127#issuecomment-464426347, or mute the thread https://github.com/notifications/unsubscribe-auth/ArvXZ7TGSXREPNtpoUSKaR6QtpU7jditks5vOQocgaJpZM4a8Dn6 .