search

CyprienBosserelle / BG_Flood

Numerical model for simulating shallow water hydrodynamics on the GPU using an Adaptive Mesh Refinment type grid. The model was designed with the goal of simulating inundation (River, Storm surge or tsunami). The model uses a Block Uniform Quadtree approach that runs on the GPU but the adaptive/multi-resolution/AMR is being implemented and not yet operational. The core SWE engine and adaptivity has been inspired and taken from St Venant solver from Basilisk and the CUDA GPU memory model has been inspired by the work from Vacondio _et al._2017)
GNU General Public License v3.0
33 stars 15 forks source link

ABS 1D BND not fully working #5

Open CyprienBosserelle opened 5 years ago

CyprienBosserelle commented 5 years ago

Working only for water level that is stable?

Needs a full test suite to verify what does and doesn't work.

uumean is forced to 0.0 in the function thus imposing a forced no mean flux along the boundary which is completelly imcompatible with bnd with variable condition.

How is that going to work with horizontal discharge of RIver along the boundary?

CyprienBosserelle commented 5 years ago

This is properly working after bugfix (108642e8e995446989229175bd823f2351cb5ed7)

uumean is tsill set to 0 so it probably won't properly work on high frequency waves forcing.

CyprienBosserelle commented 3 years ago

Indeed this has not really been resolved and more work needs to be done to store and reuse umean

CyprienBosserelle commented 2 years ago

Confirming there is a bug here in the latest version to do with wet/dry interface. This urgently needs attention.

CyprienBosserelle commented 1 year ago

The wet/dry instability has been tamed to some degrees and probably improved with the new bug fixes but more testing is required to confirm this is fully working.

CyprienBosserelle commented 1 year ago

uumean is still forced to 0.0. so that part is not working yet.