Closed AliceHarang closed 1 year ago
Hi, Do you think we would need to add the possibility of reading these variables as constant? (next to the actual "map mode")
Right now the user has to force the IL and CL as maps an although I though it may be useful to allow a constant value everywhere , I think the way it is now is preferable. It forces you to think what to do in the ocean (il and cl =0.0) and river bed.
Few things I'd like to see added (I can help do that)
Sorry for the pedantic comment about adding a md file for the documentation but I think we need to do that for every PL. That way the documentation doesn't run away from us. I will add that to every pull request for now on....
Hi, I do agree with the md file, we need to know what is in the code. For the initial value for the ocean/estuaries, do you want to force it over the user map? For the moment, if there is a user map, we use it; if there is no IL and CL input, there is no infiltration (everything should have a on/off switch).
Regarding the output var name, I didn't have much inspiration... (it is the (accumulated) height of water infiltrated through this cell up to this time)
I did the initial condition for initial loss (infiltration = il where h>eps ) I will think of better output name variable and propose a name.
Regarding the documentation md file, I made a basic word document that I can quickly transform in a md file.
I added a md file to explain the model. Do you think it is sufficient? (Can you clarify the figure of expected results?)
A sanity check on outvars to be sure that the model/options are in phase with the requested outputs. Done for ic/cl/hgw Done for datmpdx/datmpdy
This objective is to add a model of Initial and Continuous Loss to the code. This model aims to add a very basic model of ground infiltration, in order to improve the surface runoff when rain on grid is used. An initial loss of water is estimated before the runoff begin, then a constant volume of rain, the continuous loss is remove when the runoff occurs. These values are defined, based on the material of the ground, at each cell location.
Discuss:
Steps: