Map output timesteps rounding error

CyprienBosserelle / BG_Flood

Numerical model for simulating shallow water hydrodynamics on the GPU using an Adaptive Mesh Refinment type grid. The model was designed with the goal of simulating inundation (River, Storm surge or tsunami). The model uses a Block Uniform Quadtree approach that runs on the GPU but the adaptive/multi-resolution/AMR is being implemented and not yet operational. The core SWE engine and adaptivity has been inspired and taken from St Venant solver from Basilisk and the CUDA GPU memory model has been inspired by the work from Vacondio _et al._2017)

GNU General Public License v3.0

34 stars 15 forks source link

Map output timesteps rounding error #72

Closed AliceHarang closed 1 year ago

AliceHarang commented 1 year ago

The error was coming from the user.

[x] : Add a sanity check on the outputtimestep to force a final output
[x] : Add some log to communicate to the user the change of endtime if boundaries are not defined long enough
[x] : River: Add a t0/tmax for the river and log+modify simu range
[x] : Wind Time serie: add sanity check, log and modify simu range
[x] : Dynamic forcings (Atm, Rain, Wind): add sanity check, log and modify simu range
[x] : tested with River TS and Dynamic forcing

AliceHarang commented 1 year ago

I think that this should be good for all available time varying input (needed up to the end of the simu). Let me know if I forgot one. I tested in with bad boundary TS, river TS, rain dyn frocing. I didn't test the wind TS forcing (which has different implementation).

AliceHarang commented 1 year ago

This branch is ready for review and merging. This is a very small PR with mainly adding test to input and warning/modification of the simulation parameter range if needed.

The TS input for wind (independent) has not been tested.