Instability Fix - Githubissues

CyprienBosserelle / BG_Flood

Numerical model for simulating shallow water hydrodynamics on the GPU using an Adaptive Mesh Refinment type grid. The model was designed with the goal of simulating inundation (River, Storm surge or tsunami). The model uses a Block Uniform Quadtree approach that runs on the GPU but the adaptive/multi-resolution/AMR is being implemented and not yet operational. The core SWE engine and adaptivity has been inspired and taken from St Venant solver from Basilisk and the CUDA GPU memory model has been inspired by the work from Vacondio _et al._2017)

GNU General Public License v3.0

34 stars 15 forks source link

Instability Fix #74

Closed CyprienBosserelle closed 1 year ago

CyprienBosserelle commented 1 year ago

This branch creates new test for detecting instability at the wet and dry interface. It also solves initial issues with instability caused by bugs in the code.

[x] Create a consistent test with instability present
[x] Fix Bugs in Refine
[x] Fix bugs in Conserve elevation
[x] check that using "conserve elevation" the test is successful (and small error only without conserve elevation)
[x] redesign the test
[x] manual check with rain on grid
[x] manual check with tsunami

CyprienBosserelle commented 1 year ago

Manual test shows that this is 22-24% faster than the code in Dev branch