CyprienBosserelle / xbeach_gpu

Lightweight version of XBeach that uses CUDA C to run on the GPU. The code is used to simulate coastal waves, currents, sediment transport and beach morphology changes during extreme events. Visit:
http://cyprienbosserelle.github.io/xbeach_gpu/
GNU General Public License v3.0
13 stars 1 forks source link

Some bathymetry grid sizes are not immediately friendly to XBGPU #34

Open davidbenncsiro opened 2 years ago

davidbenncsiro commented 2 years ago

We have found it necessary to sometimes change the bathymetry grid in order for XGBPU to not yield unexpected results, e.g. by cutting the first row and column.

It would be good for XBGPU to be able to detect and correct for this automatically.

hot007 commented 2 years ago

Hi @CyprienBosserelle , I don't want to pressure you on this issue at all, just wondering what your projected time to address this issue might be? It affects whether we assume it will be done in the next 6mo, say, or we add warnings into our conversion code when the input grids might not work with XB-GPU.

CyprienBosserelle commented 2 years ago

I definitely want to fix that issue and there are two ways of dealing with this.

XBGPU does need a bit of attention but I'm flat out for the next 4-6 month so I don't think I can do the second option any time soon. If extending grids as part of the conversion is not acceptable I can try to squeeze option 1.

davidbenncsiro commented 1 year ago

We may yet be able to provide an intermediate workaround by including the ability to modify the bathymetry file via the conversion script if necessary.

davidbenncsiro commented 1 year ago

A somewhat related issue is the apparent need to double up the last rows and columns in the bathy file, at least in some scenarios.