Problems in the future - Githubissues

Cyrexxis / RokTracker

Open Source Rise of Kingdoms Stats Management Tool. Track TOP X Players of kingdom / alliance / honor leaderboard.

MIT License

47 stars 18 forks source link

Problems in the future #3

Closed Cyrexxis closed 1 year ago

Cyrexxis commented 1 year ago

Currently two python packages are used that use the depricated setup.py method to install, those packages will break with pip 23.1 according to a warning during installation.

Affected Packages:

[x] scikit-learn (because it's a very old version, but currently working on removing it completly)
[x] pure-python-adb (that's the bigger problem, didn't find a replacement yet)

Edit: Updated list to reflect current progress (see in the first comment)

Cyrexxis commented 1 year ago

Commit 62f5a745f1dae1f2919184f98ade3583b7ec5b45 tackled the first problem. Now scikit-learn is no longer needed. Regarding the replacement for pure-python-adb i will try adbutils.

Cyrexxis commented 1 year ago

This issue is closed now. It turned out adbutils had a very old dependency with the same problem as pure-python-adb so i switched to AndroidViewClient even though that seems like a bit of a overkill for this usecase.