search

Cyrexxis / RokTracker

Open Source Rise of Kingdoms Stats Management Tool. Track TOP X Players of kingdom / alliance / honor leaderboard.
MIT License
44 stars 18 forks source link

General code cleanup #46

Closed Cyrexxis closed 9 months ago

Cyrexxis commented 9 months ago

Is your feature request related to a problem? Please describe. There are some duplicate code in the different scanners and also some files that are not needed anymore (.ps1 and .bat files). Also there are some vulnerabilities in the requirements, so it would be advisable to update them.

Describe the solution you'd like Move duplicated code into seperate file and reuse that file, delete no longer needed files. Update dependencies and test if everything still works.

Cyrexxis commented 9 months ago

It is would also be a good idea to get a proper understaning how to use logging in pyton and apply that to the scanner and other modules.