search

Cyrexxis / RokTracker

Open Source Rise of Kingdoms Stats Management Tool. Track TOP X Players of kingdom / alliance / honor leaderboard.
MIT License
47 stars 18 forks source link

Update bundling method #53

Closed Cyrexxis closed 11 months ago

Cyrexxis commented 11 months ago

Is your feature request related to a problem? Please describe. Currently there is much duplication in downloading, when you want different exe files. It would be better to offer one single download with all exe files included.

Describe the solution you'd like Use the feature of pyInstaller to do that.

Cyrexxis commented 11 months ago

It seems due to an update of the pyinstaller dependency (from version 5 to version 6) now I always get a false antivirus warning when bundling the UI Version without console. Apparently only the empty bootloader is flagged though, meaning that the bundled EXE works normal. Just need to remember to whitelist the build folder. It might be possible to circumvent that by building my own bootloader and then use it instead of the prebuilt one. However, that seems like it is much work.

Cyrexxis commented 11 months ago

It was easier than I thought. Since all needed build tools are install in the runner (and my PC) you can easily compile the bootloader at installation time with the env variable: PYINSTALLER_COMPILE_BOOTLOADER before installing with pip.