CyrielRct / midea_ac_lan

Auto-configure and then control your Midea M-Smart devices (Air conditioner, Fan, Water heater, Washer, etc) via local area network.
MIT License
41 stars 3 forks source link

fix blocking call in event loop, and add dev/test tooling #9

Closed attilaersek closed 1 month ago

attilaersek commented 1 month ago

Hey!

First of all, I'd like to thank all your efforts you've put into resurrecting this project! I was worried that this integration is not maintained anymore, I hope you'll accept my very first contribution. I'm not a python developer (at all!) and I'm definitely not a HomeAssistant custom integration developer, so please triple test everything. I do my best to test my changes!

What's included:

and a special commit that bumps versions and changes the component owner to you, @CyrielRct !

Let me know if you'd like to change something.

attilaersek commented 1 month ago

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

Qianli-Ma commented 1 month ago

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

On second thought, I believe that you are correct. Let's keep the developer tooling.

attilaersek commented 1 month ago

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

On second thought, I believe that you are correct. Let's keep the developer tooling.

Appreciate your quick response and openness! Let me know if I can help somehow!