search

CyrilCommando / SankakuCacher

Chrome extension that does a couple things for chan.sankakucomplex.com, automatically download images on sankakucomplex
37 stars 3 forks source link

Error: invalid filename #10

Closed PenguinM closed 7 months ago

PenguinM commented 1 year ago

When the tag contains “:" it prompts an invalid filename, but in fact, this tag can be found. For example, date:<=2023-08-01

CyrilCommando commented 1 year ago

So, you're right about the error but not the character. I do things like voted:x or fav:x all the time. I had never used the date tag before so I didn't know it included the = and <> characters. Those would cause the error.

I'll fix it asap. Thanks for telling me.

CyrilCommando commented 1 year ago

Alright, it's done. Download from the master branch.

PenguinM commented 1 year ago

Impressive repair speed! XD However, I'm currently using version 1.10.1 due to the fact that using v2 or the master branch plugins results in an error : "Could not establish connection. Receiving end does not exist."

CyrilCommando commented 1 year ago

Ok I managed to recreate that error. It must be a chrome thing. It only happens on chrome beyond 115 maybe. I tested for any issues and didn't find any so the error must be benign. I'll keep testing but I don't expect to find any and Windows 10 managed to brutally slaughter my entire PC while I was booting it to test for this very issue. I may be delayed. Lol.

I recommend to use the master branch. There will be issues otherwise especially with 1.10 because they've launched tons of changes that introduced issues since then. Like the addition of the AI panel up top.

PenguinM commented 1 year ago

That was crazy lol. My environment is Windows 11 x64 with Chrome version 116. I tried various versions from 115 down to 98 until it finally worked. XD

The AI panel did indeed lead to download offset, but now it's perfectly resolved. Nice work!