search

CyrilleB79 / outlookExtended

This addon for NVDA screen reader improves the use of Microsoft Outlook by vocalizing some commands and adding extra commands
GNU General Public License v2.0
2 stars 6 forks source link

Code proposal: lint and type annotations #3

Open josephsl opened 2 years ago

josephsl commented 2 years ago

Hi Cyrille,

First, thanks for your hard work on Outlook Extended add-on.

I would like to propose a general code linting and type annotations. As you may know, NVDA uses Flake8 for linting purposes, and parts of the screen reader source code include type annotations. After running the add-on source code with Flake8, I noticed that there are things that could see improvements with linting such as lines just filled with tab characters.

To perform lint with Flake8, install Flake8 and Flake8-tabs, then:

  1. From command line (PowerShell, for example), move to the root of the add-on source code.
  2. Provided that Flake8 is installed, run flake8 addon/source/file

Thanks.

CyrilleB79 commented 1 year ago

Linting fixed in 28ec7fe85479c908d5277809ea7716e11abfa30b.

I keep this issue open in case I add type annotations in the future.