Cyrix126 / gupaxx

Fork of Gupax integrating the XMRvsBeast Raffle
https://xmrvsbeast.com
GNU General Public License v3.0
21 stars 3 forks source link

feat: add XvB options, refactor & improve algorithm #11

Closed mostafaei2002 closed 2 months ago

mostafaei2002 commented 4 months ago
Cyrix126 commented 4 months ago

Changes needed to merge

UI:

Same UI for simple sub-menu

the UI for simple tab should not be different from before. The hero checkbox should not be replaced by a drop down menu. The reason is that when you only have two choice a checkbox makes more sense since you need to make only one click instead of two to choose the other mode. Since Gupaxx is intended to be a easy to use GUI, this design detail is important.

keep XvB logo

The logo of XvB should not be removed as it is a link to the website easily seen. If there is not enough height space, you must add scroll bar.

Optional: Slider instead of input

Instead of having an input, a slider with % of HR or a number based on runtime xmrig would prevent user putting numbers above what their rig can offer.

Backend:

Pass all the CI checks

You can enable them for your branch by setting main to dev in .github/workflows/*.yml

mostafaei2002 commented 4 months ago

Requested Changes

New feature

Cyrix126 commented 4 months ago

Changes needed to merge

UI

Backend

mostafaei2002 commented 4 months ago

All requested changes were implemented.

Ideas

Cyrix126 commented 4 months ago
* Instead of disabling the slider when xvb is not alive change it to when xmrig hashrate is lower than a number. IMO users should be able to set the donation amount before xvb getting started. This improves UX.

I agree. But let's say it is limited on HR numbers from xmrig after the first 10 seconds are obtained, like the algo do.

And adding a hovering help message so users understand that their set value can change if it's too much for xmrig.

For maximum value before the 10s you can set a thousand so that the slider will scale nicely (it's the same in Status P2Pool sub). MH/s should be also added in this case. With the decimal separator, users will have good control over the value.

The numbers after decimal should be no more than 3 to be like the account stats.

* Change the names for ManuallyDonate, ManuallyKeep names. I am thinking of ManualXvb instead of ManuallyDonate  and ManualP2pool instead of ManuallyKeep. These names are more self explanatory.

ok good. Also the names once the mode is selected should be the same as in the drop menu. Right now the menu show names with a space when the selected name is in camel .

mostafaei2002 commented 4 months ago

All the changes are implemented plus a few extra minor changes. There could be some other changes here and there that are needed I'll proceed to run the program and test it in the upcoming days.

Cyrix126 commented 4 months ago

rust formatting checks failed. Since your branch is not up to date with upstream, your CI runs were missing the new ones.

Cyrix126 commented 3 months ago

need to fix: