search

Cyrix126 / gupaxx

Fork of Gupax integrating the XMRvsBeast Raffle
https://xmrvsbeast.com
GNU General Public License v3.0
31 stars 4 forks source link

include the WinRing0x64.sys file by default in the /xmrig folder #21

Closed DeanLemans closed 3 weeks ago

DeanLemans commented 1 month ago

Feature request include the WinRing0x64.sys file by default in the /xmrig folder

Additional context https://github.com/Cyrix126/gupaxx/issues/16 if the WinRing0x64.sys file is not pressent in the xmrig folder then the hashrate will be low 373383181-0f8f5712-593b-4a2f-903e-0c32961861ee to fix this you could perhaps include the WinRing0x64.sys file by default in the windows-bundle.zip

Cyrix126 commented 1 month ago

I can't reproduce the issue on a fresh Windows 10 VM. Before adding this file, I want to know in which cases it is needed.

MKRajan29 commented 1 month ago

It might be needed when the user is installing Gupaxx anew without extracting the new bundle into the old directory. maybe.

Cyrix126 commented 1 month ago

It might be needed when the user is installing Gupaxx anew without extracting the new bundle into the old directory. maybe.

I can't see why. There is no need to extract to old directory, it will just replace older ones. And if you already have a Gupaxx version, you can update from it anyway.

MKRajan29 commented 1 month ago

But updating keeps it in the older directory itself. Just the same way the 'Rig' in Xmrig tab doesn't change with updating eventhough it should. So is the old directory's name.

Cyrix126 commented 3 weeks ago

The reason it is needed in xmrig directory on some Windows system and not other is simply because it can sometimes be available system-wide. xmrig release includes it by default, but original project gupax was only including the binary.

In the next version of Gupaxx, the WinRing0 driver will be included in case the system doesn't have it.

Just a note that WinRing0 current version included with xmrig has a security issue.

This issue will be close on the next release including https://github.com/Cyrix126/gupaxx/commit/8b3d6d7cda4a4bb3ffac74a81e48878fad42cdba

Cyrix126 commented 3 weeks ago

closed by release v1.5.2