search

Cyrix126 / gupaxx

Fork of Gupax integrating the XMRvsBeast Raffle
https://xmrvsbeast.com
GNU General Public License v3.0
31 stars 4 forks source link

ping node is not always accurate #30

Closed Cyrix126 closed 3 weeks ago

Cyrix126 commented 3 weeks ago

Bug

Since node does not implement ICMP, HTTP requests are made to find the latency of remote nodes (including the ones of XvB). Since only one request per node is made, the latency found can be a bit random. Currently, this means the list of remote nodes and the automatic chosen XvB node can sometimes be inaccurate.

Steps

Steps to reproduce the behavior:

  1. Go to P2pool tab

  2. Click on "Ping remote nodes"

  3. See that the results is not always accurate.

  4. Start XvB process

  5. See that sometimes the output console says that the wrong one has been chosen.

Solution

When testing the latency, make multiples request and take average.

Cyrix126 commented 3 weeks ago

fixed in https://github.com/Cyrix126/gupaxx/commit/5a4759109f90971baf3c6ee43a0facf4d3486547 and https://github.com/Cyrix126/gupaxx/commit/279bdcc678bcf5b116587a1a3369fee727fd1bc6

Issue will be closed at next release.

Cyrix126 commented 3 weeks ago

closed by release v1.5.2