search

Cyrix126 / gupaxx

Fork of Gupax integrating the XMRvsBeast Raffle
https://xmrvsbeast.com
GNU General Public License v3.0
31 stars 5 forks source link

over estimate of external HR when proxy used with external miners and all HR sent to a node #31

Closed Cyrix126 closed 3 weeks ago

Cyrix126 commented 3 weeks ago

Version

Since Gupaxx v1.3.0

Bug

When the algo runs, it will at every decision record the current local HR to keep track of what it sent where, to be able to calculate the external HR based on sent and total.

When using Proxy, algo should watch his HR instead of xmrig, but doesn't and record only HR of the latter when sending all HR to a node(p2pool or XvB), in case of no shares or 24h average fast reach.

No consequence until a change of decision that will stop sending all HR to a node. Then too few sent HR will be estimated which could over raise the estimated external HR.

Having an overestimate of external HR can lower the required HR to be sent. The algo should resolve the issue with next decisions up to an hour when it realize external HR doesn't exist in the total HR, except if a new decision direct all HR to a node and the behavior repeats again.

This bug doesn't not impact HR on XvB because of https://github.com/Cyrix126/gupaxx/issues/33

Steps

Steps to reproduce the behavior

  1. Start Proxy with external miners connected to it
  2. Start XvB algo in either auto/manual round selection
  3. Have no share
  4. All HR is sent to p2pool
  5. having a share, now algo think all HR sent to p2pool is external except for the HR of xmrig
  6. It will not send less than recommended HR on p2pool but will take an hour at most to send it correctly again.
Cyrix126 commented 3 weeks ago

fixed by https://github.com/Cyrix126/gupaxx/commit/cc7301d9c34369555779a98a78cfba218d1f7eed issue will be closed by next release.

Cyrix126 commented 3 weeks ago

closed by release v1.5.2