Use NullabilityInfoContext to replace Type's Nullable detection

Cysharp / MagicOnion

Unified Realtime/API framework for .NET platform and Unity.

MIT License

3.9k stars 433 forks source link

Use NullabilityInfoContext to replace Type's Nullable detection #854

Closed SmRiley closed 1 month ago

SmRiley commented 1 month ago

.NET 6 provides NullabilityInfoContext to detect whether parameters are nullable. The existing Type.IsNullable method cannot detect nullable reference types (such as string?), and a utility class file with identical content has been removed.

mayuki commented 1 month ago

Thank you for your contribution!

I'm very sorry, but MagicOnion.Server.HttpGateway will be removed from the main (v7.x) branch soon. We plan to re-implement HTTP/1 access using a similar approach to Microsoft.AspNetCore.Grpc.JsonTranscoding, and use Swagger provided by ASP.NET Core.

If possible, please submit a PR to the release/6.x branch, and we will be able to release it as a new version of 6.x.

SmRiley commented 1 month ago

OK, thank you for your contribution to the project, and look forward to the early arrival of this feature