Closed OpenEnergyGroup closed 1 month ago
Hi, the Dispose pattern of Subject does not implement
Subject
protected virtual void Dispose(bool disposing){ ... }
it's instead
public void Dispose(bool callOnCompleted)
which makes it impossible to inherit from Subject with a class that needs to call its own Dispose before the base. The canonical Microsoft solution examples are here .
Thank you!
Subject is not designed to be inherited, if it is misleading as such, it should be sealed.
Hi, the Dispose pattern of
Subject
does not implementit's instead
which makes it impossible to inherit from Subject with a class that needs to call its own Dispose before the base. The canonical Microsoft solution examples are here .
Thank you!