Double clicking the log line in the console doesn't open the file from which the log was initiated

Cysharp / ZLogger

Zero Allocation Text/Structured Logger for .NET with StringInterpolation and Source Generator, built on top of a Microsoft.Extensions.Logging.

MIT License

1.14k stars 80 forks source link

Double clicking the log line in the console doesn't open the file from which the log was initiated #62

Closed igor84 closed 1 year ago

igor84 commented 1 year ago

Instead it opens ZLoggerExtensions file. The only way I know to solve this is to distribute ZString and ZLogger as precompiled DLLs since Unity will then open the first file that is not from DLL.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

hadashiA commented 9 months ago

Thanks for the suggestion. So we considered that Unity's [HideInCallstack] attribute, but decided not to support it because of the following:

ZLogger does not seem to be able to cleanup the stack trace completely because it goes through lambda expressions, etc.
HideInCallstack] is needed even for Unity-independent parts, but the source code seems to be a bit complicated.
It may not be complete because the behavior depends on the Console window settings.