search

Cysu / open-reid

Open source person re-identification library in python
https://cysu.github.io/open-reid/
MIT License
1.34k stars 349 forks source link

RandomPairSampler is missing #6

Closed jaxony closed 7 years ago

jaxony commented 7 years ago

Great library! The implementation for RandomPairSampler is missing from utils/data/sampler.py. Will it be implemented any time soon? It sounds like something useful for loading input data for a verification task.

Cysu commented 7 years ago

We implemented a RandomPairSampler in an earlier version of the library. But later it was removed as the API for learning models with siamese structure and joint embedding was not well designed. A temporary (but maybe better) solution is to generate pairs inside a mini-batch, just like what the triplet loss did.