search

Cytnx-dev / Cytnx

Project Cytnx, A Cross-section of Python & C++,Tensor network library
Apache License 2.0
35 stars 13 forks source link

remove relabels from the API #481

Open pcchen opened 2 weeks ago

pcchen commented 2 weeks ago

It seems that .relabels() still exist. Please double check. We should remove it(them) from the API.

jeffry1829 commented 2 weeks ago

It’s deprecated to make sure old program compatibility Do we need to remove it? Thanks!

Pochung Chen @.***>於 2024年9月24日 週二，下午10:45寫道：

It seems that .relabels() still exist. Please double check. We should remove it(them) from the API.

— Reply to this email directly, view it on GitHub https://github.com/Cytnx-dev/Cytnx/issues/481, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUUA2KVWHAW6V5FMAO6IMDZYF3J3AVCNFSM6AAAAABOYPQS46VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DKNRSGI2TMNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yingjerkao commented 2 weeks ago

Since we are not yet v1.0 yet, I think it is ok to remove it. We should have proper protocol for deprecation though. We can keep the code, throwing a deprecation warning, but remove the API in the documentation.

jeffry1829 commented 2 weeks ago

No problem, I’ll remove it

Ying-Jer Kao @.***>於 2024年9月25日 週三，下午2:00寫道：

Since we are not yet v1.0 yet, I think it is ok to remove it. We should have proper protocol for deprecation though. We can keep the code, throwing a deprecation warning, but remove the API in the documentation.

— Reply to this email directly, view it on GitHub https://github.com/Cytnx-dev/Cytnx/issues/481#issuecomment-2373099870, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUUA2MV4LWV47N7DDQDREDZYJGRVAVCNFSM6AAAAABOYPQS46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTGA4TSOBXGA . You are receiving this because you commented.Message ID: @.***>