search

Cytnx-dev / Cytnx

Project Cytnx, A Cross-section of Python & C++,Tensor network library
Apache License 2.0
35 stars 14 forks source link

Remove Magma dependency by using CuSolver Routines #483

Closed yingjerkao closed 1 month ago

yingjerkao commented 1 month ago

This PR attempts to remove the Magma dependency by replacing magma routines with the corresponding cusolver ones.

It compiles CUDA 11.8, CuTensor 2.0.2.5, CuQuantum 24.08.0.5.

yingjerkao commented 1 month ago

It looks like the tests and coverage don't cover the gpu version?

jeffry1829 commented 1 month ago

It looks like the tests and coverage don't cover the gpu version?

Yes, one possible option is that we might need to link some machine to github action

jeffry1829 commented 1 month ago

I'll push test for Det later(along with some fixes), however, cusolver getrf is ridiculously slow, might investigate more

IvanaGyro commented 1 month ago

@jeffry1829 Could you create another PR for https://github.com/Cytnx-dev/Cytnx/pull/483/commits/35c95aa2296d8a37afb56dab50dddbb38d04070d ? So this PR doesn't have to wait for the commit for fixing the Det.

jeffry1829 commented 1 month ago

@jeffry1829 Could you create another PR for 35c95aa ? So this PR doesn't have to wait for the commit for fixing the Det.

Reverted

yingjerkao commented 1 month ago

Fix #482