search

CytopiaTeam / Cytopia

:deciduous_tree::house_with_garden::office::evergreen_tree: A city building simulation game
https://www.cytopia.net
GNU General Public License v3.0
1.97k stars 105 forks source link

Separated music and sfx #1000

Closed lizzyd710 closed 2 years ago

lizzyd710 commented 2 years ago

Now you can adjust music volume and SFX volume separately. Don't know if we can truly test this until we figure out how to fully test Soundtracks, but that's a whole other project.

dalerank commented 2 years ago

Good, pls recheck linux build

lizzyd710 commented 2 years ago

I don't know if I'll be able to get the code to pass the quality gate because of the duplication thing. That is a separate issue which I will try and take care of in a refactor of AudioMixer

lizzyd710 commented 2 years ago

Don't know what's up with Conan and the dependencies for these checks.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication