AudioMixer refactor - Githubissues

CytopiaTeam / Cytopia

:deciduous_tree::house_with_garden::office::evergreen_tree: A city building simulation game

https://www.cytopia.net

GNU General Public License v3.0

1.97k stars 105 forks source link

Closed lizzyd710 closed 2 years ago

lizzyd710 commented 2 years ago

Main things:

combined playSoundtrackWithReverb and playSoundtrackWithEcho into playSoundtrackWithEffect reducing duplicate code that was pissing off sonarcloud
reduced the play overloads from 12 to 4 by turning the effect into optional parameters
Removed the echo and reverb structs since that's no longer needed. They held the same values as the effect's default properties, so it was just setting the values to the same numbers they already had.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!