Closed DanielMowitz closed 2 years ago
Oh wow, this is awesome, thank you! I don't know why sonarcloud is throwing a fit, but all the checks pass so that's the key part. I'll play around with it and give a review.
As an aside, the format-files.sh
script changed 16 additional files that I haven't touched at all. Maybe the Shell script/clang handles formatting a bit differently to the windows/js one?
… and with this commit it even compiles :+1:
Kudos, SonarCloud Quality Gate passed!
As an aside, the
format-files.sh
script changed 16 additional files that I haven't touched at all. Maybe the Shell script/clang handles formatting a bit differently to the windows/js one?
Maybe. It's also possible that those files were formatted wrong. (As you saw in some other files you changed in this PR someone was doing weird formatting so that's entirely possible.)
This is an overall naïve implementation, in the sense that it copies the height of the initial selected node and applies it to the whole area.
The main factors for code complexity stem from:
The first point might be mitigated though by deciding on only having rectangular selection for levelling (see #1016).
Sloped node behavior
Slopes should lower the terrain when the selection is pulled from the lower side:
levels to
They should raise the terrain when the selection goes the other way:
levels to
Edged slopes should behave the same:
levels to
In all screenshots the rectangle was dragged up from the lowest edge (I couldn't more meaningful screenshots, sorry).