Cytraen / BungieSharper

A .NET client library for the Bungie.net API.
MIT License
15 stars 1 forks source link

Destiny2_GetProfile needs to send an empty list if no components are given #36

Closed PatrickMatthiesen closed 2 years ago

PatrickMatthiesen commented 2 years ago

the server returns 500 if the components part is not in the URL in the header

Cytraen commented 2 years ago

Is there something wrong with giving an empty list manually? The OpenAPI spec doesn't say whether a query param is required or not, and I would prefer to not add a special case for individual endpoints.

The API documentation states You must request at least one component to receive results anyway so I don't see a reason to change this.

PatrickMatthiesen commented 2 years ago

I’m kinda new to using open source libraries, but I just didn’t see it in the code documentation (might just have missed it), but bungie does say it in their doc. So was mostly for convenience when using your library.

Cytraen commented 2 years ago

The documentation in BungieSharper is a direct copy-paste of the Bungie documentation. The bit I quoted is under the documentation for the components parameter.