D-Niermann / BreadCalculator

Graphical user friendly calculator for your bread recipes. Runs on Windows. Programmed with electron. Can be build on any system.
15 stars 3 forks source link

Suggestion -> orphaned branch from master to main #9

Open simonneutert opened 2 years ago

simonneutert commented 2 years ago

master isn't the preferred branch anymore, see here: https://github.blog/changelog/2020-10-01-the-default-branch-for-newly-created-repositories-is-now-main/

and your repository seems to have loads of legacy code and files in it, the download was huge.

my suggestion is to orphan branch from master

git checkout --orphan main

then push main and in the repository settings switch to main as the main branch 😉

you can then delete the master branch, with all its (maybe private files) afterwards 💪

D-Niermann commented 2 years ago

and your repository seems to have loads of legacy code and files in it, the download was huge. It includes all node modules so thats why it is so big I think. Idk if they could be reduced. I could check but thats not so important I think. It will be huge non the less. It has 70MB for me, for a normal user it should be of any concern. And thanks for the tutorial on how to change the branch name :)

simonneutert commented 2 years ago

just bad practice then, see:

https://github.com/github/gitignore/blob/main/Node.gitignore

easy to fix and makes a better impression

D-Niermann commented 2 years ago

Ah you mean that the repo is so big. Yes that cannot really be changed because it includes the dowloadable .zip file, which has to be big because it has to include all node_modules. The repo itself already ignores it. I could work with GitHub Releases I think. Maybe then the .zip is not included in the repo?

simonneutert commented 2 years ago

die zip hängt man hier in GitHub an einen release/tag mit an dann können user auch unterschiedliche Versionen wählen. das erhöht dann ebenfalls das vertrauen