Not updated: geographic coordinates for societies in 'tdwg societies' file

D-PLACE / dplace-data

The data repository for the D-PLACE Project (Database of Places, Language, Culture and Environment)

https://d-place.org

Creative Commons Attribution 4.0 International

77 stars 37 forks source link

Not updated: geographic coordinates for societies in 'tdwg societies' file #280

Closed kirbykat closed 11 months ago

kirbykat commented 4 years ago

It looks like lat/long coordinates for societies Koreans (Ed1) and Negri Sembilan (Ej16) in this file have not been updated/corrected, while those in the datasets > EA > societies.csv file HAVE. I'm believe (but am not sure - @xrotwang?) that the tdwg societies file is only used for display/mapping on the site. Can we pull the tdwg lat/lon from individual society.csv files?

Updated (columns "Lat" and "Long": https://github.com/D-PLACE/dplace-data/blob/master/datasets/EA/societies.csv

Not updated: https://github.com/D-PLACE/dplace-data/blob/master/geo/societies_tdwg.json

xrotwang commented 4 years ago

societies_tdwg.json is only used to populate the region attribute - so the issue shouldn't have any effect on the app (or most analyses). The file will be regenerated when dplace tdwg is run, i.e. when a new release is created.

xrotwang commented 4 years ago

I'll leave the issue open until I run dplace tdwg (to confirm that I was correct above :) ).

kirbykat commented 4 years ago

@xrotwang that sounds good, but in that case should it have updated when 2.1 was released? The changes to the coordinates of Koreans (Ed1) and Negri Sembilan (Ej16) were made before the release of 2.1, I'm almost certain. Thanks!

kirbykat commented 4 years ago

(My concern is for people who try to build a flat file for analysis, and decide to pull lat lon from the tdwg file instead of from the societies file. Obvs. not a big deal, but will start introducing errors/make things less reproducible.)

SimonGreenhill commented 4 years ago

yeah, we need to make a new release of DPLACE very soon

xrotwang commented 4 years ago

@kirbykat yes, you are right, there's potential for confusion. I think I didn't re-run the region identification, because there were no new societies (between 2.0 and 2.1). @SimonGreenhill and I were thinking about some sort of CLDFy release format for D-PLACE data. This might help in making more transparent what we think should be used and how.

SimonGreenhill commented 1 year ago