Bit of code cleanup, fix small bug with cultural variable count, more JS tests

[stefelisabeth]

• Fixed minor bug where cultural variable count wasn't resetting properly when the model was reset.

• Moved some functions for cultural/environmental search into individual controllers because it makes more sense for them to be there

• Previously, each controller had its own "doSearch() function, which looked a bit like this: function doSearch() { $scope.search(); } where $scope.search() was in the Search Controller. This seemed a bit redundant, so I moved the search button to search.html and linked it directly to search(). Now there is one search button for the whole app, instead of four buttons (one for each controller) as previously. I guess there is some benefit to separating them if each controller has a unique search function, but they don't.

• Updated the tests to reflect changes in point above

• Added tests for models.js and environmental.js.

[codecov-io]

Codecov Report

Merging #584 into master will increase coverage by 0.63%. The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   69.69%   70.33%   +0.63%     
==========================================
  Files          41       41              
  Lines        2541     2545       +4     
==========================================
+ Hits         1771     1790      +19     
+ Misses        770      755      -15

Impacted Files	Coverage Δ
...ace_app/static/js/controllers/search/geographic.js	100% <ø> (ø)	:arrow_up:
...place_app/static/js/controllers/search/language.js	95.83% <ø> (-0.17%)	:arrow_down:
...place_app/static/js/controllers/search/variable.js	1.38% <0%> (+0.05%)	:arrow_up:
...place_app/static/js/controllers/search/cultural.js	7.14% <0%> (-0.55%)	:arrow_down:
..._app/static/js/controllers/search/environmental.js	88.88% <100%> (+68.88%)	:arrow_up:
dplace_app/static/js/controllers/search.js	90.11% <77.77%> (-0.85%)	:arrow_down:
dplace_app/static/js/models.js	100% <0%> (+6.15%)	:arrow_up:
dplace_app/static/js/controllers/app.js	55.17% <0%> (+27.58%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5958f6f...812260a. Read the comment docs.

[SimonGreenhill]

Thanks Stef!