Emcl/sql alchemy dbs - Githubissues

D-Star-AI / dsRAG

High-performance retrieval engine for unstructured data

MIT License

996 stars 65 forks source link

Emcl/sql alchemy dbs #42

Open emclaughlin215 opened 3 months ago

emclaughlin215 commented 3 months ago

Overall Questions:

Maybe this is not a useful level of abstraction and really what is needed are PostgreSQL DBs. (chunk/postgres_db, vector/postgres_db)
I am not entirely sure what supp_id is and so it is not used in the implementation for SQLAlchemyDB

Some things to look at:

Imports needed from SQL Alchemy (I don't think my poetry aligns with yours)
Making sure Vector works for non-postgres dbs using SQLAlchemy
Adding tests

zmccormick7 commented 2 months ago

Given the popularity of PostgreSQL, I do think it could make more sense to just call these PostgreSQL vector/chunk databases instead of SQLAlchemy. And then we don't have to worry about supporting things other than PostgreSQL here.

emclaughlin215 commented 2 months ago

@zmccormick7 what is supp_id?

zmccormick7 commented 2 months ago

supp_id is just any additional identifier you want to add. It could be something like a customer id for example.