search

D-X-Y / AutoDL-Projects

Automated deep learning algorithms implemented in PyTorch.
MIT License
1.57k stars 282 forks source link

[TAS] Question about resnet basicblock architecture. #65

Closed kwonbeomseok closed 4 years ago

kwonbeomseok commented 4 years ago

Thank you for your great work and sharing code.

I have a question about ResNet basicblock. https://github.com/D-X-Y/AutoDL-Projects/blob/569b9b406ae8331fbbb130c97be35f0a9f313abf/lib/models/shape_searchs/SearchCifarResNet_width.py#L159 There is no activation function(Relu) output of basicblock in search forward. Is there a reason you didn't put it in?

D-X-Y commented 4 years ago

Nice catch. It should be a bug. Thanks for pointing out!

D-X-Y commented 4 years ago

@kwonbeomseok I just push a new commit to fix this issue: https://github.com/D-X-Y/AutoDL-Projects/tree/076f9c2d41dc888b8087c266261d2094c8739340

Please let me know if you have further questions.