search

D00Med / LegendofMinetest

Minetest game based on Legend of Zelda
15 stars 7 forks source link

Bad or low-quality item names #15

Open Wuzzy2 opened 7 years ago

Wuzzy2 commented 7 years ago

These are all actual item names:

And in general, some item names may need a general rewrite for a consistent style. This subgame can't decide whether to capitalize every word, or only use lowercase.

Version 2.

D00Med commented 7 years ago

Ok I will work on fixing this.

mckaygerhard commented 2 years ago 
* “doomshrooms_mushpick”

✅ seems SOLVED as Mushpick in doomshrooms

* “magicpowder”

📛 PENDING ISSUES: i canot find nay item like this, i only found a reference in xdecor/cooking.lua so maybe was changed or has missing things.. @D00Med i need more information cos browsing the commits was a mess

* “seedsatchet(ember)” and similar: Missing space. Also, this is a very odd name. I would suggest something like “Seed Bag (Ember)”

✅ SOLVED

* “Cave Crystal”: Identical name for 3 different items

✅ SOLVED at hyrule_mapgen/nodes.lua with pull #39 

* “Exotic”: should be “Exotic Fish” or somthing like this

✅ SOLVED at fishing/fishes.lua with pull #39 but we have a little miscpelled at fishing/prizes.lua fishing/trophies.lua and fishing/functions.lua .. so i just referenced this issue later to get as task to separate the word used, also the translations makes their own interpretation.. so about this is not so finished but related to the issue is solved!

* “tall mushroom 2” doesn't sound very creative ;-)

✅ SOLVED now but i guess there 📛 PENDING ISSUES: there's many mushrooms references and other mods so maybe in future we must check this

And in general, some item names may need a general rewrite for a consistent style. This subgame can't decide whether to capitalize every word, or only use lowercase.

Version 2.

✅ SOLVED as most in mayor level with the pull #39 merged .. this issue can be closed now @D00Med thanks in advance (lest remenber only port and stability for now)

D00Med commented 2 years ago

Seed satchet is a typo: https://zelda.fandom.com/wiki/Seed_Satchel

mckaygerhard commented 2 years ago

was more easy you give the item name.. i sear5ched for a hour in the code.. hyruletools:seed_satchel well .. curently it said "seed bad" .. so the description is pending .. and we must check the rest of item one by one.. if there's a problem are minors like the model has missing the logo and the description is pending.. but this issue mus be let opened and we must changed the title to "[task] item description checks revision" to fix things like "Seed bad" to "Seed satchet" .. (models is a mayor task so let to other issue in the long future

screenshot_20220130_103411

D00Med commented 2 years ago

Are you referring to the item models? They aren't supposed to have descriptions or readable names, since they are placed with code (iirc).

mckaygerhard commented 2 years ago

umm so then that item is good to be named "Seed bad" even "Seed satchet" ok good so if author are happy .. then since pull #39 this issue are done..

but i dont know if the item in hyruletools must have right descriptions. (as i guess, the seed satchet is a copy of the seed bad so we must change or not or defined that description that already exists?.. ) if not.. then close this issue.. but then we must remove those

D00Med commented 2 years ago

umm so then that item is good to be named "Seed bad" even "Seed satchet" ok good so if author are happy .. then since pull #39 this issue are done..

No no, I'm sorry. That's an ok correction. I just mean that things like the 3d models shouldn't have descriptions if they don't have them already.

but i dont know if the item in hyruletools must have right descriptions. (as i guess, the seed satchet is a copy of the seed bad so we must change or not or defined that description that already exists?.. ) if not.. then close this issue.. but then we must remove those

Not sure what you mean.