D00Med / LegendofMinetest

Minetest game based on Legend of Zelda
15 stars 7 forks source link

Fix Error for math.random(low#,high#) requirement #35

Closed jcfrosty closed 2 years ago

jcfrosty commented 6 years ago

Fix Error for math.random(low#,high#) requirement

jcfrosty commented 6 years ago

20180623_153547 1

D00Med commented 6 years ago

Again? :S I thought I'd fixed it all. It's certainly fixed on the update branch. Also why are you getting this error? It's important to find out because this error will mess up situations with two variables inside the function: math.random(variable,variable2) Where either number could be larger than the other.

jcfrosty commented 6 years ago

Lua 5.1 limitation possibly?

On Tue, Jun 26, 2018 at 4:26 PM D00Med notifications@github.com wrote:

Again? :S I thought I'd fixed it all. It's certainly fixed on the update branch. Also why are you getting this error? It's important to find out because this error will mess up situations with two variables inside the function: math.random(variable,variable2) Where either number could be larger than the other.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-400467796, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGWEhsOIM2dviIkQ_iJcQHvF8YAOpks5uAqbsgaJpZM4U4mj2 .

D00Med commented 6 years ago

Hm, sorry to ask again, but which version of minetest are you using? and where did you get it? (as in, is it a custom build or something?)

jcfrosty commented 6 years ago

minetest version 4.17 Not a custom build, its from a Sabayon Repository. Sabayon is based on Gentoo which uses ebuilds. ebuilds basically pull source code directly from approved source (typically originator) and compile/install. Sabayon does this action, but packages it in prebuilt form and places them into a repository for downloads/installs/updates.

On Wed, Jun 27, 2018 at 4:46 PM D00Med notifications@github.com wrote:

Hm, sorry to ask again, but which version of minetest are you using? and where did you get it? (as in, is it a custom build or something?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-400839640, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGZsYLnhVSQLi_e47vfOU04oO8ekLks5uA_1PgaJpZM4U4mj2 .

D00Med commented 6 years ago

Hmm, so I guess you can't use the downloads from the minetest website?

jcfrosty commented 6 years ago

Thats exactly what Gentoo uses. it downloads the source from the minetest website and compiles it.

On Thu, Jun 28, 2018 at 4:22 PM D00Med notifications@github.com wrote:

Hmm, so I guess you can't use the downloads from the minetest website?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-401177524, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGV9fv0_tV9itQso9w6AEk0IKCH8Rks5uBUkbgaJpZM4U4mj2 .

D00Med commented 6 years ago

You haven't had this problem with any other mods or subgames, have you?

jcfrosty commented 6 years ago

Haven't really tried any other mods/subgames. I did try just the original minetest game with no issues.

On Thu, Jun 28, 2018 at 8:01 PM D00Med notifications@github.com wrote:

You haven't had this problem with any other mods or subgames, have you?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-401216878, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGWcPoCc4uqWzQcfnlEPnx9W6uXNXks5uBXxhgaJpZM4U4mj2 .

D00Med commented 6 years ago

And there's no way your version could be compiled wrong?

jcfrosty commented 6 years ago

Nope, afraid not. the normal minetest game runs just fine.

On Thu, Jun 28, 2018 at 10:22 PM D00Med notifications@github.com wrote:

And there's no way your version could be compiled wrong?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-401236039, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGQkPVEhcMYq4Du2DPqqZaNLvOEYXks5uBZ2KgaJpZM4U4mj2 .

D00Med commented 6 years ago

Can you have a go with another mod or subgame? like mobs redo? That way we'd know where the problem is.

jcfrosty commented 6 years ago

sure. I'll test it and let you know what happens.

On Thu, Jul 5, 2018 at 4:57 PM D00Med notifications@github.com wrote:

Can you have a go with another mod or subgame? like mobs redo? That way we'd know where the problem is.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/D00Med/LegendofMinetest/pull/35#issuecomment-402864890, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGRaDfj_91xCSMQAndorymn0EdyOiks5uDovXgaJpZM4U4mj2 .

D00Med commented 6 years ago

Thanks

jcfrosty commented 6 years ago

OK, I've tested Regnum-3.2.9 . Not sure I understand the point of that game, but OK. It only had one issue with the music loading mod, after i removed that one plugin, Game ran smooth, no other issues.

I figured it could be my version of lua so I upgraded to 5.3.3 from 5.1, no change. So I tried recompiling and installing minetest 4.7.1, no change.

All the errors I get are the same errors no matter what I do.

mckaygerhard commented 2 years ago

OK, I've tested Regnum-3.2.9 . Not sure I understand the point of that game, but OK. It only had one issue with the music loading mod, after i removed that one plugin, Game ran smooth, no other issues.

I figured it could be my version of lua so I upgraded to 5.3.3 from 5.1, no change. So I tried recompiling and installing minetest 4.7.1, no change.

All the errors I get are the same errors no matter what I do.

this change was already integrated since #39 was merged! related commits are