search

D00Med / farlands

Steampunk/fantasy themed subgame with dinosaurs
29 stars 11 forks source link

some leaves don't decay #124

Open MarkuBu opened 6 years ago

MarkuBu commented 6 years ago

Some leaves like Willow and Palm don't decay, if all trunks are removed

tobyplowy commented 6 years ago

@MarkuBu thanks for reporting :)

MarkuBu commented 6 years ago

I'm a bit confused. Now I cut a jungle tree, but the leaves don't decay. Than I plant a new jungle tree from a sapling and this time the leaves decay when I cut the tree

tobyplowy commented 6 years ago

@MarkuBu that's odd :/

MarkuBu commented 6 years ago

Only you own trees placed by the mapgen don't decay. Default trees work fine. Don't know why yet.

Who made the tree schematics?

MarkuBu commented 6 years ago

Got it. param2 of the leaves is set to 1, but should be 0. param2=1 is reserved for leaves that are placed by the player.

tobyplowy commented 6 years ago

@MarkuBu can you change the param types?

MarkuBu commented 6 years ago

That's why I asked who made the schematics. It would be a lot of work for me to convert all MTS files to lua, edit them and convert them back to MTS. I don't want to do that.

It would be easyer for the original creator to change that, depending on how they were made

tobyplowy commented 6 years ago

@MarkuBu d00med made the tree schematics also I did a couple

tobyplowy commented 6 years ago

@D00Med ping

MarkuBu commented 6 years ago

@tobyplowy how did you make them? Build a tree and save it with a schematic saver?

I always used the schematic saver from duane and I preferred to save the schematic as Lua table instead of MTS.

Take a look to my tree mod

https://github.com/MarkuBu/mb_trees

tobyplowy commented 6 years ago

@MarkuBu furst I build them in game and than I exported them using wuzzys exporter

MarkuBu commented 6 years ago

I would recommend using a Lua table to store schematics. I don't see the advantage of MTS. Just saves a few bytes and a few microseconds while loading

I used the schematic saver from duane.

tobyplowy commented 6 years ago

@MarkuBu I think it's better that d00med takes this over

I'm not very good at this smart poeple stuff :/

D00Med commented 6 years ago

@tobyplowy Thanks @MarkuBu I've been using worldedit. But I intend to use wuzzy's exporter in future.

MarkuBu commented 6 years ago

@D00Med can you save the schematics as Lua table and upload them here?

D00Med commented 6 years ago

@MarkuBu do you want them as lua tables so you can set param2?

MarkuBu commented 6 years ago

param2 shouldn't be set at all. I don't know why it is set to 1, but it definitely is. A Lua table is the only way to change this.

It is also handy to have the Lua table if you want to make changes, not only for the trees, but for all schematics.

Schematics can be converted to MTS for a stable release, but for development I prefer the Lua table

D00Med commented 6 years ago

@MarkuBu Oh ok, well then shouldn't mts files be fine? Minetest game uses mts files, and they're easier to create, so I figure they are better to use.

MarkuBu commented 6 years ago

Well, MTS files are used for one reason: they save a few bytes of space. Might be interesting if you have a (very) slow Internet connection.

But MTS is a binary format. You can't edit them. And it should be as easy as creating a MTS file. Maybe Wuzzys mod can save as Lua or can be modified to do that.