Use code from itemframes mod for powered_stand and itemholder

D00Med / scifi_nodes

Minetest mod that adds scifi themed nodes

Other

12 stars 18 forks source link

Use code from itemframes mod for powered_stand and itemholder #22

Closed OgelGames closed 4 years ago

OgelGames commented 4 years ago

Fixes issues: https://github.com/pandorabox-io/pandorabox.io/issues/341 and https://github.com/pandorabox-io/pandorabox.io/issues/293

D00Med commented 4 years ago

I don't particularly want to merge this. I thought my way of using the itemholder was quite elegant.

OgelGames commented 4 years ago

I agree that your method is much simpler, but the problem is that it uses the default dropped item entity, which means any player (and vacuum tubes) can pick up the item. By using a custom entity, and using add_entity() instead of add_item(), the only way to pick up the item is by clicking the holder.

D00Med commented 4 years ago

I don't really see that as a problem.

OgelGames commented 4 years ago

That isn't the only bug fixed with the new code, it's just the one that requires the most additional code; here are the bugs that are fixed with the new code:

displayed items can be picked up by pipeworks' vacuum tube
placing and removing an item removes the item's metadata (can be used for instantly repairing tools and armor)
displayed items can despawn just like dropped items
the itemholder's protection is only effective one way (items can be removed by any player, but only placed by the owner)
both the itemholder and powered_stand can be moved by mesecons' pistons and movestones

D00Med commented 4 years ago

hmmm, I still would prefer not to change anything

SwissalpS commented 2 years ago

the itemholder's protection is only effective one way (items can be removed by any player, but only placed by the owner)

I don't mind that, but am not against adding that too for UX concistancy with [itemframes].