search

D00Med / scifi_nodes

Minetest mod that adds scifi themed nodes
Other
12 stars 18 forks source link

needles check? itemholder #67

Open SwissalpS opened 2 years ago

SwissalpS commented 2 years ago

I don't see where the item meta field is ever set: https://github.com/D00Med/scifi_nodes/blob/1558b4c1463fdba5fc1e796d04cfcdb239785908/nodeboxes.lua#L1111

on_destruct() seems pointless.

Did I overlook something?

itemframes and pedestals set that value [homedecor_modpack/itemframes] but sci_fi stands do not. Also itemframes and pedestals protect their items while sci_fi counterparts give free gifts, behaviour which I like.

SwissalpS commented 2 years ago

actually setting the 'item' field would make replacer:inspect more accurate, but it doesn't depend on it.

While testing I encountered another odity: works best with powered_stand, itemholder does this too but seems not as much.

This is core stacking nearby entities at work. The work-around would be to add unstackable entity like pedestals do.

Edit: I think the time interval between placing the items has an influence. It also seems that the items are then timed-out after a while, because I have empty stands some time after doing this.

BuckarooBanzay commented 2 years ago

Did I overlook something?

nope, this looks pointless... :+1:

Also, fyi: https://github.com/pandorabox-io/pandorabox_custom/blob/22a83072a4a8456c9689e178387b380d1e68c0f2/scifi_override.lua#L155

And the discussion in #22 about the itemstand overhaul

SwissalpS commented 2 years ago

Thanks, yes the 'insta-repair-patch' does fix all these issues and more.