search

D00Med / scifi_nodes

Minetest mod that adds scifi themed nodes
Other
12 stars 18 forks source link

Better lightbars. #82

Closed acmgit closed 6 months ago

acmgit commented 6 months ago

Makes lightbars fully rotateable.

BuckarooBanzay commented 6 months ago

Good idea, but:

already placed lightbars have a param2 that does not map 1:1 to the facedir rotation:

Before your commit: screenshot_20240302_174407

Afterwards: screenshot_20240302_174500

(i had the same idea a while back and already tried this :wink:)

An alternative would be to introduce another new node with facedir as param2 (you could even tweak it a bit to look a bit different)

Or:

Write an lbm that migrates the wallmounted param2 to the facedir param2 on the existing node

acmgit commented 6 months ago

At this case, the way with the lbm would be cheapest and fastest. What happens? I have to turn the bars into a new position .. I use replacer for this ....

Is not a absolutely new case in minetest, after an update of an mod.

BuckarooBanzay commented 6 months ago

What happens? I have to turn the bars into a new position .. I use replacer for this .... Is not a absolutely new case in minetest, after an update of an mod.

I would be pretty mad from a builder perspective if i had to redo my work after a mod update (IMO)

acmgit commented 6 months ago

Was not the first time, that i've seen this. On my server i helped, was then a work for half an hour. We worked with the replacer and nobody has checked it ;-).

But now we have fully rotatable lightbars.

BuckarooBanzay commented 6 months ago

On my server i helped, was then a work for half an hour. We worked with the replacer and nobody has checked it ;-).

Do you volunteer to fix them on all the servers out there using this mod? :smirk:

acmgit commented 6 months ago

Of course not ;-).