Closed GoogleCodeExporter closed 8 years ago
When using CROP_MODE_TOP, how would you expect a landscape-oriented photo to be
cropped? To the left, center, right, or other?
Original comment by joe.lencioni
on 9 Nov 2010 at 6:23
I would expect it to crop center (I think) - so that just left, right and
bottom sides got cropped.
I use this funtion in Photoshop quite often, since I'm working a lot with
images of people.
Original comment by spsti...@hotmail.com
on 11 Nov 2010 at 11:37
After considering this, I think I'm going to split out the cropping code into
different classes, which will be able to act as filters on the image. This will
allow you to specify which cropping "filter" you want to use and will make it
easier to add more filters for more specific situations like yours in the
future.
Original comment by joe.lencioni
on 16 Dec 2010 at 3:08
Sounds like a good plan.
When reading your question again, I see you asked for landscape images. I would
still just crop left, right and bottom, because normally the most important
part of a picture is at the top, not at the bottom.
Original comment by spsti...@hotmail.com
on 17 Dec 2010 at 8:54
This issue was closed by revision r116.
Original comment by joe.lencioni
on 21 Dec 2010 at 3:46
Original issue reported on code.google.com by
spsti...@hotmail.com
on 9 Nov 2010 at 2:54