search

D2R-Reimagined / d2r-reimagined-mod

The source code for the Diablo II Mod Reimagined. Found on nexus mods here: https://www.nexusmods.com/diablo2resurrected/mods/34
23 stars 32 forks source link

Missing Strings #142

Open Bakelt opened 1 week ago

Bakelt commented 1 week ago

In uniqueitems.txt there appears to be a set of Rainbow Facets1-7 and Sapphire Facet1 that have no counterpart in item-names.json Also not sure why Rainbow1-7 exist as they look like a duplicate of the 7 other "Rainbow Facet"

Harald92 commented 3 days ago

I'll look into it

victoria-riley-barnett commented 14 hours ago

Was this a hacky way to increase number of Facets that could be rolled into? I just noticed this as well - I run a 3 to 1 unique jewel reroll and rolled into "An Evil Force" facet. I'm going to test with Rainbow Facet1-7 removed, and Rainbow Facet entries set to nolimit 1

victoria-riley-barnett commented 14 hours ago

Nevermind - uniqueitems.txt from next already removes these numbered rainbow facets!

victoria-riley-barnett commented 14 hours ago

image

However, something is still missing a string, as you can roll this

victoria-riley-barnett commented 14 hours ago

I suspect a more robust naming nomenclature for the pierce jewels is needed image

victoria-riley-barnett commented 13 hours ago

image image image image

I'm gonna suggest PRing my gem changes, which swap from "Rainbow Facet" in favor of new names. My only question - there is a rainbow facet (and only a rainbow facet, no others) in uniques.json, should this be swapped as well?

My PR will only be my successful changes, which include renaming the "death skill" facets similar to the season themed set, and renaming the level skill facets to synonyms I liked :) and their entries into item-names.json