Output stark components

D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite

http://d3denergetic.github.io/FIDASIM/

Other

29 stars 19 forks source link

Output stark components #183

Closed alvin-garcia closed 4 years ago

alvin-garcia commented 4 years ago

Hello @lstagner,

Please review this PR related to task item 1 in Issue 182. I have checked all spectra produced by our test modeling suite on all channels for OMP and MPI runs using full and MC distribution functions. Below is a screenshot of my Jupyter Notebook.

Screen Shot 2020-02-06 at 11 55 25 AM

Thank you.

lstagner commented 4 years ago

So many if statements...

Why didn't you just extend the existing spectrums to include the stark components e.g.

spec%fida(nwav,chan,class) --> spec%fida(n_stark, nwav, chan, class)

I thought we already decided that the increase in memory was negligible.

Basically, we always store the stark components and we just change what is written to the file when stark_components is set.

alvin-garcia commented 4 years ago

@lstagner,

I misunderstood what you wrote. Please review the new commit. Thanks. stark_comparison