D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite
http://d3denergetic.github.io/FIDASIM/
Other
29 stars 19 forks source link

Srh/output res #218

Closed shaunhaskey closed 3 years ago

shaunhaskey commented 3 years ago
lstagner commented 3 years ago

Can you change output_reservoir to neutral_reservoir to give some hint the users.

shaunhaskey commented 3 years ago

@lstagner How about output_neutral_reservoir? or too long?

lstagner commented 3 years ago

Oh yeah if output isn't in the name how will users know what it does. 🤦 Yeah output_neutral_reservoir works fine.

shaunhaskey commented 3 years ago

Output thermal_lambda0 and thermal_mass in spectra.h5 file:

2020-12-14_11-01

lstagner commented 3 years ago

Is there anything else? If not i'll merge it in.

shaunhaskey commented 3 years ago

@lstagner I didn't mess with prefida related things... do I need to?

lstagner commented 3 years ago

You can if you want but you don't have to. I will merge this tomorrow and if you included the prefida changes then great and if you didn't then thats fine too.

alvin-garcia commented 3 years ago

@shaunhaskey,

Please add output_neutral_reservoir to relevant prefida scripts below:

In /lib/idl/, write_namelist.pro & check_inputs.pro In /lib/python/fidasim, preprocessing.py In /test/, run_tests.pro & run_tests.py

Thanks 😄

shaunhaskey commented 3 years ago

@alvin-garcia Did not add anything to run_tests.py and run_tests.pro because prefida should automatically set the values if they weren't specified

lstagner commented 3 years ago

I'm just going to merge this. If there are any problems we will fix it later.