Closed shaunhaskey closed 3 years ago
Can you change output_reservoir
to neutral_reservoir
to give some hint the users.
@lstagner How about output_neutral_reservoir? or too long?
Oh yeah if output isn't in the name how will users know what it does. 🤦 Yeah output_neutral_reservoir
works fine.
Output thermal_lambda0 and thermal_mass in spectra.h5 file:
Is there anything else? If not i'll merge it in.
@lstagner I didn't mess with prefida related things... do I need to?
You can if you want but you don't have to. I will merge this tomorrow and if you included the prefida changes then great and if you didn't then thats fine too.
@shaunhaskey,
Please add output_neutral_reservoir
to relevant prefida scripts below:
In /lib/idl/
, write_namelist.pro
& check_inputs.pro
In /lib/python/fidasim
, preprocessing.py
In /test/
, run_tests.pro
& run_tests.py
Thanks 😄
@alvin-garcia Did not add anything to run_tests.py and run_tests.pro because prefida should automatically set the values if they weren't specified
I'm just going to merge this. If there are any problems we will fix it later.