D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite
http://d3denergetic.github.io/FIDASIM/
Other
27 stars 18 forks source link

Bremsstrahlung is limited to within 3m of FIDA LOS lens #255

Open hayashiw opened 1 year ago

hayashiw commented 1 year ago

Bremsstrahlung will only be calculated when plasma is within 3m (max_length <= 300cm) of the FIDA lens (with a small margin for random sampling around the lens): https://github.com/D3DEnergetic/FIDASIM/blob/11fb75191e4da3f50b5d930944ef86ff323a7dec/src/fidasim.f90#L11616-L11621

This fails to calculate bremsstrahlung for geometries like this one used for the Large Helical Device: image The mesh grid shows the plasma interpolation grid. The green and yellow lines are neutral beams. The blue and red lines are FIDA LOS from 2 different views. The pink shows 3m from the lenses along the sightlines.

One solution could be to just increase the max_length out to some larger value, maybe 10m? @lstagner is there a specific reason to keep it at 3m? If not, and you're okay with this solution, then I can implement this fix.

alvin-garcia commented 1 year ago

Increasing to 10 m will solve the issue since it would seem to accommodate even a large device like ITER. However, a safer approach would be to calculate the length based on the geometry of the detector and size of the machine. I did something like this for calculation of the passive neutral grid. This would take more time to develop in FIDASIM, but would avoid unnecessary “in_plasma” checks for smaller devices.

On Tue, Nov 15, 2022 at 11:20 PM Wataru H J Hayashi < @.***> wrote:

Bremsstrahlung will only be calculated when plasma is within 3m ( max_length <= 300cm) of the FIDA lens (with a small margin for random sampling around the lens):

https://github.com/D3DEnergetic/FIDASIM/blob/11fb75191e4da3f50b5d930944ef86ff323a7dec/src/fidasim.f90#L11616-L11621 https://urldefense.com/v3/__https://github.com/D3DEnergetic/FIDASIM/blob/11fb75191e4da3f50b5d930944ef86ff323a7dec/src/fidasim.f90*L11616-L11621__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!LfTSyuU2NwfDLZCIYT7U3_T_hpIu2b3ZSUu5MLI0eVZRl-PMhmwMnxfnqbIvurIdMwp_uJj0aNdU01QLPhBP593pePI$

This fails to calculate bremsstrahlung for geometries like this one used for the Large Helical Device: [image: image] https://urldefense.com/v3/__https://user-images.githubusercontent.com/71105393/202081351-3d6e4ea5-db1d-404e-993c-22074f9a2eb2.png__;!!CzAuKJ42GuquVTTmVmPViYEvSg!LfTSyuU2NwfDLZCIYT7U3_T_hpIu2b3ZSUu5MLI0eVZRl-PMhmwMnxfnqbIvurIdMwp_uJj0aNdU01QLPhBPFXUpkJw$ The mesh grid shows the plasma interpolation grid. The green and yellow lines are neutral beams. The blue and red lines are FIDA LOS from 2 different views. The pink shows 3m from the lenses along the sightlines.

One solution could be to just increase the max_length out to some larger value, maybe 10m? @lstagner https://urldefense.com/v3/__https://github.com/lstagner__;!!CzAuKJ42GuquVTTmVmPViYEvSg!LfTSyuU2NwfDLZCIYT7U3_T_hpIu2b3ZSUu5MLI0eVZRl-PMhmwMnxfnqbIvurIdMwp_uJj0aNdU01QLPhBPXnZgmGA$ is there a specific reason to keep it at 3m? If not, and you're okay with this solution, then I can implement this fix.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/D3DEnergetic/FIDASIM/issues/255__;!!CzAuKJ42GuquVTTmVmPViYEvSg!LfTSyuU2NwfDLZCIYT7U3_T_hpIu2b3ZSUu5MLI0eVZRl-PMhmwMnxfnqbIvurIdMwp_uJj0aNdU01QLPhBPIs85gig$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AIABRPPPD7V3GWXG66VP4ZDWIROJNANCNFSM6AAAAAASBY3FUE__;!!CzAuKJ42GuquVTTmVmPViYEvSg!LfTSyuU2NwfDLZCIYT7U3_T_hpIu2b3ZSUu5MLI0eVZRl-PMhmwMnxfnqbIvurIdMwp_uJj0aNdU01QLPhBP_L5SoFo$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Alvin Garcia PhD Candidate, Physics University of California, Irvine LinkedIn https://www.linkedin.com/in/alvingarciav/

lstagner commented 1 year ago

The bremsstrahlung calculation doesn't take much time. So feel free to make the quick fix and if its a problem we can do a smarter solution.