Discrepancy in the NPA neutral flux between FIDASIM3.0-dev and FIDASIM2.0

D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite

http://d3denergetic.github.io/FIDASIM/

Other

27 stars 18 forks source link

Discrepancy in the NPA neutral flux between FIDASIM3.0-dev and FIDASIM2.0 #271

Closed deyongl closed 6 months ago

deyongl commented 8 months ago

There exists some discrepancy in the magnitude of the NPA neutral flux between the latest FIDASIM in GitHub and FIDASIM 2.0. It is found that the difference started to appear in the FIDASIM version after pull request 187. The simulation results before the pull request 187 agree well with FIDASIM2.0.

lstagner commented 6 months ago

I finally found the bug. Its now fixed on master. The issue was that the rate matrix calculation didn't correct for the fast-ion contribution. In #186 this was included in the denp variable but since we now provide deni which is just the thermal ions it was left out accidently when I updated the other instances of denp.